Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for uwsgi.status.worker.rss field #24468

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

jsoriano
Copy link
Member

What does this PR do?

Fix type for uwsgi.status.worker.rss field.

It was defined as keyword, but it is a number.

Generate different data files for the different kinds of events
generated by this metricset: overall, cores and workers.

Why is it important?

Use a proper data type, and include example data files with this field.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

It was defined as keyword, but it is a number.

Generate different data files for the different kinds of events
generated by this metricset: overall, cores and workers.
@jsoriano jsoriano added bug review Team:Integrations Label for the Integrations team labels Mar 10, 2021
@jsoriano jsoriano self-assigned this Mar 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 10, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24468 updated

  • Start Time: 2021-03-10T11:31:49.534+0000

  • Duration: 55 min 39 sec

  • Commit: 9424023

Test stats 🧪

Test Results
Failed 0
Passed 8319
Skipped 2261
Total 10580

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8319
Skipped 2261
Total 10580

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Mar 10, 2021
@jsoriano
Copy link
Member Author

/test

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit a9c98e2 into elastic:master Mar 10, 2021
@jsoriano jsoriano deleted the uwsgi-worker-rss branch March 10, 2021 15:08
jsoriano added a commit to jsoriano/beats that referenced this pull request Mar 10, 2021
It was defined as keyword, but it is a number.

Generate different data files for the different kinds of events
generated by this metricset: overall, cores and workers.

(cherry picked from commit a9c98e2)
@jsoriano jsoriano added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 10, 2021
jsoriano added a commit that referenced this pull request Mar 11, 2021
It was defined as keyword, but it is a number.

Generate different data files for the different kinds of events
generated by this metricset: overall, cores and workers.

(cherry picked from commit a9c98e2)
v1v added a commit to v1v/beats that referenced this pull request Mar 16, 2021
…reporting-changes

* upstream/master: (23 commits)
  [Auditbeat] btmp offset check (elastic#24515)
  Clarify that the Tomcat module is for ingesting access logs (elastic#24543)
  [Ingest Manager] Move logging defaults to agent (elastic#24535)
  Update input-http-endpoint.asciidoc (elastic#24490)
  Fix typo in mqtt input docs (elastic#24509)
  [Elastic Agent] Add verification check when updating communication to Kibana. (elastic#24489)
  Refactor use of system.hostfs to fix cgroup metrics (elastic#24334)
  Add test for close.reader.after_interval to filestream input (elastic#24423)
  chore(ci): use beat_version instead of PR version (elastic#24446)
  Add syntax for multiple selector logging (elastic#24207) (elastic#24497)
  Update Golang to 1.15.9 (elastic#24442)
  [Elastic Agent] Add the ability to provide custom CA's inside of docker. (elastic#24486)
  Add tests for encoding settings of filestream input (elastic#24426)
  [Ingest Manager] Sync on rename on windows (elastic#24504)
  Port four Harvester tests of log input to filestream in Golang (elastic#24250)
  [DOCS] Restructure content for SSL settings (elastic#24342)
  Move example to the correct location in reference docs (elastic#24455)
  Add unit tests for harvester.go of input-logfile package (elastic#24107)
  Fix type for uwsgi.status.worker.rss field (elastic#24468)
  [Ingest Manager] Logging to file disabled on enroll (elastic#24466)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Integrations Label for the Integrations team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants